Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix trait's name typo in integrating custom view lib #1223

Merged
merged 1 commit into from
Nov 7, 2024
Merged

docs: fix trait's name typo in integrating custom view lib #1223

merged 1 commit into from
Nov 7, 2024

Conversation

amiraiman
Copy link
Contributor

@amiraiman amiraiman commented Nov 7, 2024 •
edited by datamweb
Loading

Description
Typo in trait's name

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

datamweb
datamweb approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@datamweb datamweb added the documentation Improvements or additions to documentation label Nov 7, 2024
@datamweb datamweb merged commit de8e234 into codeigniter4:develop Nov 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianberkman christianberkman christianberkman approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amiraiman @datamweb @christianberkman