Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signup URL to authconfig payload #464

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

alexeykazakov
Copy link
Contributor

Required for #438
There is a new redirect page in that PR ^^^ which is supposed to do the following:

  • it loads the authconfig from /api/v1/authconfig
  • then if the user is not logged in already then it redirects the user to SSO for login
  • then it checks if the user has already signed up. If not then the page redirects the user to the signup page.

This PR adds the signup URL (we store it as registrationServiceURL in the configuration) to the authconfig payload, so it's available to the clients in the last step above.

Copy link

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.46%. Comparing base (cbd0f40) to head (36c1237).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   79.45%   79.46%           
=======================================
  Files          42       42           
  Lines        2726     2727    +1     
=======================================
+ Hits         2166     2167    +1     
  Misses        471      471           
  Partials       89       89           
Flag Coverage Δ
unittests 79.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, ranakan19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,ranakan19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov alexeykazakov merged commit d7ff96d into codeready-toolchain:master Sep 23, 2024
10 of 11 checks passed
@alexeykazakov alexeykazakov deleted the signupURL branch September 23, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants