-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the latest go-jose 2.x. #432
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 77.47% 77.61% +0.13%
==========================================
Files 49 49
Lines 2007 2426 +419
==========================================
+ Hits 1555 1883 +328
- Misses 398 489 +91
Partials 54 54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But is the any context? I mean, sure, we want to update dependencies in general but was curious is there is something special in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this related to some CVE?
github.com/fsnotify/fsnotify v1.5.4 // indirect | ||
github.com/go-bindata/go-bindata v3.1.2+incompatible // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see go-bin data being removed, we use go-bin data at many places , I am not sure if we can remove this directly, and if we can, does the places using go-bin data get an alternative ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that this is just a 3rd party dependency, it shouldn't have an effect on the way we process the assets now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this is just a consequence of updating go-jose
. I just trusted go mod
to do the right thing with the rest of the dep changes.
Good point, @alexeykazakov. I added the link to the corresponding issue to the PR description. |
$TITLE
Issue: https://issues.redhat.com/browse/SANDBOX-556