Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest go-jose 2.x. #432

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Nov 1, 2024

Copy link

sonarqubecloud bot commented Nov 1, 2024

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.61%. Comparing base (55e8143) to head (9dc24b1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   77.47%   77.61%   +0.13%     
==========================================
  Files          49       49              
  Lines        2007     2426     +419     
==========================================
+ Hits         1555     1883     +328     
- Misses        398      489      +91     
  Partials       54       54              

see 44 files with indirect coverage changes

Copy link
Collaborator

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But is the any context? I mean, sure, we want to update dependencies in general but was curious is there is something special in this case.

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this related to some CVE?

github.com/fsnotify/fsnotify v1.5.4 // indirect
github.com/go-bindata/go-bindata v3.1.2+incompatible // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see go-bin data being removed, we use go-bin data at many places , I am not sure if we can remove this directly, and if we can, does the places using go-bin data get an alternative ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that this is just a 3rd party dependency, it shouldn't have an effect on the way we process the assets now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is just a consequence of updating go-jose. I just trusted go mod to do the right thing with the rest of the dep changes.

@metlos
Copy link
Contributor Author

metlos commented Nov 14, 2024

Looks good. But is the any context? I mean, sure, we want to update dependencies in general but was curious is there is something special in this case.

Good point, @alexeykazakov. I added the link to the corresponding issue to the PR description.

@metlos metlos merged commit f8850b6 into codeready-toolchain:master Nov 14, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants