Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create tiertemplaterevision for each tiertemplate #1061

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

feat: create tiertemplaterevision for each tiertemplate #1061

wants to merge 43 commits into from
+205 −14

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented Nov 12, 2024 •
edited
Loading

E2e tests for: codeready-toolchain/host-operator#1103

  • verifies that when creating a TierTemplate with the TemplateObjects field populated it triggers the creation of a TierTemplateRevision CR as well
  • verify owner reference of the TTR
  • verify labels are set correctly on the TTR

Jira: https://issues.redhat.com/browse/KUBESAW-146

@mfrancisc mfrancisc mentioned this pull request Nov 12, 2024
Open
Merge branch 'master' into createttr
b9e5e84 
# Conflicts:
#	testsupport/init.go
MatousJobanek
MatousJobanek reviewed Nov 19, 2024
View reviewed changes
test/e2e/parallel/nstemplatetier_test.go Show resolved Hide resolved
testsupport/wait/host.go Outdated Show resolved Hide resolved
testsupport/wait/host.go Outdated Show resolved Hide resolved
testsupport/wait/host.go Outdated Show resolved Hide resolved
test/e2e/parallel/nstemplatetier_test.go Outdated Show resolved Hide resolved
@mfrancisc
Copy link
Contributor Author

seems like some infra/flaky issue:

  proxy_test.go:385: 
        	Error Trace:	/go/src/github.com/codeready-toolchain/toolchain-e2e/test/e2e/parallel/proxy_test.go:385
        	Error:      	Received unexpected error:
        	            	configmaps "kube-root-ca.crt" not found

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/codeready-toolchain_toolchain-e2e/1061/pull-ci-codeready-toolchain-toolchain-e2e-master-e2e/1859128319136501760/build-log.txt

@mfrancisc
Copy link
Contributor Author

/retest

@mfrancisc
Copy link
Contributor Author

infra issues:

WARNING: timed out waiting for git server, will wait 1m4s
error: fatal: unable to access 'https://github.com/codeready-toolchain/toolchain-e2e.git/': Could not resolve host: github.com

/retest

rsoaresd
rsoaresd reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@rsoaresd rsoaresd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🚀 Just a minor question:

testsupport/wait/host.go Outdated Show resolved Hide resolved
@mfrancisc
Copy link
Contributor Author

/retest

MatousJobanek
MatousJobanek reviewed Dec 20, 2024
View reviewed changes
test/e2e/parallel/nstemplatetier_test.go Outdated Show resolved Hide resolved
test/e2e/parallel/nstemplatetier_test.go Outdated Show resolved Hide resolved
test/e2e/parallel/nstemplatetier_test.go Outdated Show resolved Hide resolved
test/e2e/parallel/nstemplatetier_test.go Outdated Show resolved Hide resolved
testsupport/cleanup/clean.go Outdated Show resolved Hide resolved
testsupport/cleanup/clean.go Outdated Show resolved Hide resolved
testsupport/wait/host.go Outdated Show resolved Hide resolved
testsupport/wait/host.go Outdated Show resolved Hide resolved
testsupport/wait/host.go Outdated Show resolved Hide resolved
Devtools added 2 commits January 8, 2025 20:44
@mfrancisc
Copy link
Contributor Author

/retest

1 similar comment
@mfrancisc
Copy link
Contributor Author

/retest

MatousJobanek
MatousJobanek approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great work 👍 🚀

Merge branch 'master' into createttr
d1487d0 
# Conflicts:
#	go.mod
#	go.sum
@mfrancisc
Copy link
Contributor Author

/retest

fbm3307
fbm3307 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 👏

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek, metlos, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,fbm3307,metlos,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfrancisc
Copy link
Contributor Author

I'm confused, how did. the e2e passed if the publish operator failed here 🤔

@MatousJobanek
Copy link
Collaborator

you did retest, which means that the images for the last commit were already built and pushed to quay before.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 17, 2025

@mfrancisc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e a68e63f link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metlos metlos metlos approved these changes

@fbm3307 fbm3307 fbm3307 approved these changes

@MatousJobanek MatousJobanek MatousJobanek approved these changes

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@alexeykazakov alexeykazakov Awaiting requested review from alexeykazakov alexeykazakov is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

@rsoaresd rsoaresd Awaiting requested review from rsoaresd

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mfrancisc @MatousJobanek @metlos @fbm3307 @rsoaresd @openshift-merge-robot @alexeykazakov