Bump rubocop from 1.69.2 to 1.70.0 #48

dependabot · 2025-01-10T18:19:57Z

Bumps rubocop from 1.69.2 to 1.70.0.

Release notes

RuboCop 1.70

New features

#13474: Add new Style/ItAssignment cop to detect local assignments to it inside blocks. ([@dvandersluis][])

#11013: Add new Lint/SharedMutableDefault cop to alert on mutable Hash defaults. ([@corsonknowles][])

#13612: Create new cop Lint/ConstantReassignment. ([@lovro-bikic][])

#13628: Make LSP server support quick fix code action. ([@koic][])

#13607: Support passing the target ruby version through an environment variable. ([@elliottt][])

#13628: Add support for Ruby LSP as a built-in add-on. ([@koic][])

#13284: Add new target_gem_version API to change behavior of a cop at runtime depending on which gem version is present. ([@earlopain][])

Bug fixes

#13589: Fix Lint/NonAtomicFileOperation to detect offenses with fully qualified constants. ([@viralpraxis][])

#13630: Fix CLI --format option to accept fully qualified formatter class names. ([@viralpraxis][])

#13624: Don't show warnings from Lint/Syntax when a syntax error occurs. ([@earlopain][])

#13605: Fix RuboCop::Cop::Util.to_string_literal to work correctly with frozen strings. ([@viralpraxis][])

#12393: Fix false negatives for Lint/Void inside of non-modifier conditionals. ([@GabeIsman][])

#13623: Fix false negatives for Style/MultipleComparison when setting AllowMethodComparison: false and comparing with simple method calls. ([@koic][])

#13644: Fix a false positive for Layout/EmptyLinesAroundAccessModifier when an access modifier and an expression are on the same line. ([@koic][])

#13645: Fix a false positive for Style/MethodCallWithArgsParentheses when setting EnforcedStyle: omit_parentheses and last argument is an endless range. ([@earlopain][])

#13614: Fix false positives for Style/RaiseArgs with anonymous splat and triple dot forwarding. ([@earlopain][])

#13591: Fix false positives for Lint/NestedMethodDefinition when defining a method on a constant or a method call. ([@koic][])

#13594: Fix false positives for Style/MultipleComparison when using multiple safe navigation method calls. ([@koic][])

#13654: Fix false positives for Style/RedundantInitialize when empty initialize method has arguments. ([@marocchino][])

#13608: Fix crash when running rubocop -d on a config with a remote inherit_from that causes a duplicate setting warning. ([@dvandersluis][])

#12430: Fix false negatives in Style/RedundantLineContinuation with multiple line continuations. ([@dvandersluis][])

#13638: Fix false positive for Naming/BlockForwarding when method just returns the block argument. ([@mvz][])

#13599: Fix incorrect autocorrect for Layout/HashAlignment when there is a multiline positional argument and Layout/ArgumentAlignment is configured with EnforcedStyle: with_fixed_indentation. ([@dvandersluis][])

#13586: Fix regression in Layout/SpaceAroundOperators when different comparison operators were aligned with each other. ([@dvandersluis][])

#13603: Fix Lint/LiteralInInterpolation cop error on invalid string literal. ([@viralpraxis][])

#13582: Fix Lint/NonAtomicFileOperation cop error on non-constant receiver. ([@viralpraxis][])

#13598: Fix Lint/Void cop error on if without body. ([@viralpraxis][])

#13634: Fix Style/ClassAndModuleChildren cop error on compact enforced style and unindented body. ([@viralpraxis][])

#13642: Fix Style/FloatDivision cop error if #to_f has implicit receiver. ([@viralpraxis][])

#13517: Fixes Style/HashExcept to recognize safe navigation when ActiveSupportExtensionsEnabled config is enabled. ([@lovro-bikic][])

#13585: Fix Style/HashSyntax cop error on implicit call method. ([@viralpraxis][])

#13632: Fix Style/MissingElse cop error if Style/EmptyElse's EnforcedStyle is not both and if expression contains elsif. ([@viralpraxis][])

#13659: Fix Style/MissingElse cop error if Style/EmptyElse's EnforcedStyle is not both and if expression contains multiple elsif. ([@viralpraxis][])

#13596: Fix Style/RedundantCondition cop error on parentheses and modifier if in else. ([@viralpraxis][])

#13616: Fix incorrect autocorrect for Style/RedundantRegexpArgument when the regex contains a single quote. ([@mrzasa][])

#13619: Fix Style/YodaExpression cop error in case of suffix form of operator. ([@viralpraxis][])

#13578: Update Layout/LineContinuationSpacing to ignore continuations inside a regexp or xstr. ([@dvandersluis][])

#13601: Update Style/SuperArguments to handle super with a block or with a chained method with a block. ([@dvandersluis][])

#13568: Fix NoMethodError in ConfigValidator when a Cop's config is not a Hash and raise ValidationError instead. ([@amomchilov][])

Changes

#13665: Add support for safe navigation to Style/ObjectThen. ([@dvandersluis][])

#13657: Add support for safe navigation to Layout/HashAlignment. ([@dvandersluis][])

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.70.0 (2025-01-10)

New features

#13474: Add new Style/ItAssignment cop to detect local assignments to it inside blocks. ([@dvandersluis][])

#11013: Add new Lint/SharedMutableDefault cop to alert on mutable Hash defaults. ([@corsonknowles][])

#13612: Create new cop Lint/ConstantReassignment. ([@lovro-bikic][])

#13628: Make LSP server support quick fix code action. ([@koic][])

#13607: Support passing the target ruby version through an environment variable. ([@elliottt][])

#13628: Add support for Ruby LSP as a built-in add-on. ([@koic][])

#13284: Add new target_gem_version API to change behavior of a cop at runtime depending on which gem version is present. ([@earlopain][])

Bug fixes

#13589: Fix Lint/NonAtomicFileOperation to detect offenses with fully qualified constants. ([@viralpraxis][])

#13630: Fix CLI --format option to accept fully qualified formatter class names. ([@viralpraxis][])

#13624: Don't show warnings from Lint/Syntax when a syntax error occurs. ([@earlopain][])

#13605: Fix RuboCop::Cop::Util.to_string_literal to work correctly with frozen strings. ([@viralpraxis][])

#12393: Fix false negatives for Lint/Void inside of non-modifier conditionals. ([@GabeIsman][])

#13623: Fix false negatives for Style/MultipleComparison when setting AllowMethodComparison: false and comparing with simple method calls. ([@koic][])

#13644: Fix a false positive for Layout/EmptyLinesAroundAccessModifier when an access modifier and an expression are on the same line. ([@koic][])

#13645: Fix a false positive for Style/MethodCallWithArgsParentheses when setting EnforcedStyle: omit_parentheses and last argument is an endless range. ([@earlopain][])

#13614: Fix false positives for Style/RaiseArgs with anonymous splat and triple dot forwarding. ([@earlopain][])

#13591: Fix false positives for Lint/NestedMethodDefinition when defining a method on a constant or a method call. ([@koic][])

#13594: Fix false positives for Style/MultipleComparison when using multiple safe navigation method calls. ([@koic][])

#13654: Fix false positives for Style/RedundantInitialize when empty initialize method has arguments. ([@marocchino][])

#13608: Fix crash when running rubocop -d on a config with a remote inherit_from that causes a duplicate setting warning. ([@dvandersluis][])

#12430: Fix false negatives in Style/RedundantLineContinuation with multiple line continuations. ([@dvandersluis][])

#13638: Fix false positive for Naming/BlockForwarding when method just returns the block argument. ([@mvz][])

#13599: Fix incorrect autocorrect for Layout/HashAlignment when there is a multiline positional argument and Layout/ArgumentAlignment is configured with EnforcedStyle: with_fixed_indentation. ([@dvandersluis][])

#13586: Fix regression in Layout/SpaceAroundOperators when different comparison operators were aligned with each other. ([@dvandersluis][])

#13603: Fix Lint/LiteralInInterpolation cop error on invalid string literal. ([@viralpraxis][])

#13582: Fix Lint/NonAtomicFileOperation cop error on non-constant receiver. ([@viralpraxis][])

#13598: Fix Lint/Void cop error on if without body. ([@viralpraxis][])

#13634: Fix Style/ClassAndModuleChildren cop error on compact enforced style and unindented body. ([@viralpraxis][])

#13642: Fix Style/FloatDivision cop error if #to_f has implicit receiver. ([@viralpraxis][])

#13517: Fixes Style/HashExcept to recognize safe navigation when ActiveSupportExtensionsEnabled config is enabled. ([@lovro-bikic][])

#13585: Fix Style/HashSyntax cop error on implicit call method. ([@viralpraxis][])

#13632: Fix Style/MissingElse cop error if Style/EmptyElse's EnforcedStyle is not both and if expression contains elsif. ([@viralpraxis][])

#13659: Fix Style/MissingElse cop error if Style/EmptyElse's EnforcedStyle is not both and if expression contains multiple elsif. ([@viralpraxis][])

#13596: Fix Style/RedundantCondition cop error on parentheses and modifier if in else. ([@viralpraxis][])

#13616: Fix incorrect autocorrect for Style/RedundantRegexpArgument when the regex contains a single quote. ([@mrzasa][])

#13619: Fix Style/YodaExpression cop error in case of suffix form of operator. ([@viralpraxis][])

#13578: Update Layout/LineContinuationSpacing to ignore continuations inside a regexp or xstr. ([@dvandersluis][])

#13601: Update Style/SuperArguments to handle super with a block or with a chained method with a block. ([@dvandersluis][])

#13568: Fix NoMethodError in ConfigValidator when a Cop's config is not a Hash and raise ValidationError instead. ([@amomchilov][])

Changes

#13665: Add support for safe navigation to Style/ObjectThen. ([@dvandersluis][])

... (truncated)

Commits

e2f2d5c Cut 1.70
3994f94 Update Changelog
3123800 Dont show parser warnings in Lint/Syntax
9eaedd0 Add Lint/ConstantReassignment cop
4981738 Fix to recognize safe navigation when config is enabled
6f066b8 Fix build errors related to the RubyLSP add-on specs
45cd66a [Fix #13601] Update Style/SuperArguments to handle super with a block or ...
2bfe0f7 Update Style/SuperArguments to handle super with a block or with a chaine...
5d2be60 Update Style/SuperArguments to handle super with a block
e3bcc67 Add range formatting method to the formatter add-on
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.69.2 to 1.70.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.69.2...v1.70.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

coderabbitai · 2025-01-10T18:20:06Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jan 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump rubocop from 1.69.2 to 1.70.0 #48

Bump rubocop from 1.69.2 to 1.70.0 #48

dependabot bot commented on behalf of github Jan 10, 2025

coderabbitai bot commented Jan 10, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Bump rubocop from 1.69.2 to 1.70.0 #48

Are you sure you want to change the base?

Bump rubocop from 1.69.2 to 1.70.0 #48

Conversation

dependabot bot commented on behalf of github Jan 10, 2025

RuboCop 1.70

New features

Bug fixes

Changes

1.70.0 (2025-01-10)

New features

Bug fixes

Changes

coderabbitai bot commented Jan 10, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

CodeRabbit Configuration File (`.coderabbit.yaml`)