chore(settings): fixed jumping theme changer #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe set constant height instead of always rendered icons? |
neSpecc
reviewed
Jul 19, 2024
neSpecc
approved these changes
Jul 20, 2024
elizachi
approved these changes
Jul 20, 2024
TatianaFomina
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since row height is not fixed, it depends on content,
when we add icon
checkrow's height becomes larger for some screens (text-ui-base-mediumfont-size set in rem, so for some screens font-size would be less or than 20px, so when icon added height of one certain row would be changed)Solution
Now icon
checkis always displayed, but with opacity 0, for current theme with opacity 1checkcheck