Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(settings): fixed jumping theme changer #266

Merged
merged 4 commits into from
Jul 22, 2024
Merged

chore(settings): fixed jumping theme changer #266

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce3d539
fixed theme changer styles
e11sy Jul 19, 2024
cf708cf
fix row styles for icon always to have space
e11sy Jul 19, 2024
e8f83f7
typo fix
e11sy Jul 19, 2024
f63991e
changing Row style from settings page
e11sy Jul 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/presentation/pages/Settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,12 @@
<DarkColorShemeIcon v-if="scheme === 'Dark'" />
</template>
<template
v-if="colorScheme === scheme.toLowerCase()"
#right
>
<Icon name="Check" />
<Icon
name="Check"
:style="colorScheme === scheme.toLowerCase() ? 'opacity: 1;' : 'opacity: 0;'"
TatianaFomina marked this conversation as resolved.
Show resolved Hide resolved
/>
</template>
</Row>
</Section>
Expand All @@ -82,10 +84,12 @@
<ThemePreview :theme="theme" />
</template>
<template
v-if="themeBase === theme.toLowerCase()"
#right
>
<Icon name="Check" />
<Icon
name="Check"
:style="themeBase === theme.toLowerCase() ? 'opacity: 1;' : 'opacity: 0;'"
/>
</template>
</Row>
</Section>
Expand All @@ -106,10 +110,12 @@
<ThemePreview :theme="theme" />
</template>
<template
v-if="themeAccent === theme.toLowerCase()"
#right
>
<Icon name="Check" />
<Icon
name="Check"
:style="themeAccent === theme.toLowerCase() ? 'opacity: 1;' : 'opacity: 0;'"
/>
</template>
</Row>
</Section>
Expand Down
Loading