A_STAR algorithem Implementation #582
Open
+123
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kishan-Ved @czgdp1807 https://github.com/codezonediitj/pydatastructs/actions/runs/13481779061/job/37667878320?pr=582#logs |
Kishan-Ved
suggested changes
Feb 24, 2025
pydatastructs/graphs/algorithms.py
Outdated
| pred = {v: None for v in graph.vertices} | ||
| dist[source] = 0 | ||
| from pydatastructs.miscellaneous_data_structures.queue import PriorityQueue, BinomialHeapPriorityQueue | ||
| pq = PriorityQueue(implementation='binomial_heap') |
There was a problem hiding this comment.
Suggested change
| pq = PriorityQueue(implementation='binomial_heap') | |
| pq = PriorityQueue(implementation='binomial_heap') |
pydatastructs/graphs/algorithms.py
Outdated
| pq = PriorityQueue(implementation='binomial_heap') | ||
| f_score = heuristic(source, target) | ||
| pq.push(source, f_score) | ||
| while not pq.is_empty: |
There was a problem hiding this comment.
Suggested change
| while not pq.is_empty: | |
| while not pq.is_empty: |
pydatastructs/graphs/algorithms.py
Outdated
| return dist[target], pred | ||
| if visited[current]: | ||
| continue | ||
| visited[current] = True |
There was a problem hiding this comment.
Suggested change
| visited[current] = True | |
| visited[current] = True |
pydatastructs/graphs/algorithms.py
Outdated
| visited[current] = True | ||
| neighbors = graph.neighbors(current) | ||
| if not neighbors: | ||
| continue |
There was a problem hiding this comment.
Suggested change
| continue | |
| continue |
There was a problem hiding this comment.
these changes aren't visible in the local development
There was a problem hiding this comment.
@Kishan-Ved not sure how to resolve this ? shall i git--pull once?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs or Relevant literature
Fixes #486
Brief description of what is fixed or changed
Added A* pathfinding algorithm implementation (_a_star_adjacency_list). This Algorithm uses the Manhattan distance heuristic for coordinate-based nodes and Returns shortest path distance and predecessor dictionary like other pathfinding algorithms
Other comments
used the below to pull requests
https://github.com/codezonediitj/pydatastructs/pull/283/files
https://github.com/codezonediitj/pydatastructs/pull/301/files