Revises signInWithEmailAndPassword to return an either with the error or user credential #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or user credential.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how you'd like to design the API for this package, but I'm happy to contribute and follow your lead. I come from an Elm background in FP so let me know if I can make this more Pusescripty.
Some things I'd like to improve upon/discuss in this include:
String -> Stringpart of the signature: Is it worth making a type for the email to battle passing the arguments in the wrong order?Errortype being returned: Should it be customized to account for Firebase's "auth/invalid-credential" case?