-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long resp handling #401
Open
MrOrz
wants to merge
67
commits into
master
Choose a base branch
from
long-resp-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Long resp handling #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccb77b2
to
3656927
Compare
3656927
to
753b089
Compare
Pull Request Test Coverage Report for Build 13479682573Details
💛 - Coveralls |
andyy0216
approved these changes
Jan 31, 2025
bil4444
approved these changes
Jan 31, 2025
nonumpa
reviewed
Feb 5, 2025
…st recent progress - Show loading animation insted - This measure reduces the interaction provided on the user side and is thus more straightforward
d9f5cba
to
a7ecdac
Compare
0f90662
to
456aff3
Compare
0eefbfb
to
534cd0e
Compare
- thus we should clear batch there as well
…n collector Clearing batch here would cause replies being canceled, they may think new sessions already started
…continue This allows reply token collector to report latest progress to the user while getting latest token
534cd0e
to
49913e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #395
setReplyTokenCollectorMessage(ctx: Context, message: string)
to tell the user about current progress on timeoutsingleUserHandler
to remove theisRepliedDueToTimeout
flag.send()
function to consume the reply token if it hasn't timed out or use a push message if the token has expired.Updates on tests
displayLoadingAnimation
, mocklineClient
to suppress the warning caused by sending request with invalid token to LINE server.setReplyToken()
timeout mechanism is tested insrc/webhook/handlers/__tests__/utils.test.js
webhook/handlers/utils
directly or indirectly:webhook/handlers/utils
; we addredis.quit()
insetup-jest
to stop the Redis connection to avoid open handles caused by Redis connection.jest.fn()
so that we don't accidentally create connections to Redis in the namespace for mocksredis.quit()
in setup-jest does not break the connection when redis client is instantiated under mocks.Other refactors
[...]
to logging to identify where a certain error message is fromScreenshots
process media route
Send 1 message
screen-20250131-190104.2.mp4
process batch route
Send multiple messages
multi-msg.mp4
asking article submission
Send new message
screen-20250131-201953.mp4