-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdm timeseries dog-4175 #261
Merged
Merged
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c255137
feat: intial impl of cdm timeseries
toondaey f8d76e4
feat: better cdm resources
toondaey f522775
refactor: remove unnecessary comment
toondaey e5d9843
refactor: review suggestion
toondaey 95d7ab8
feat: use internal from
toondaey 47556e0
refactor: remove comments
toondaey 9564685
test: example
toondaey b669a66
test(instance): change unit for testing
toondaey e2845cb
Merge master into cdm-timeseries/dog-4175
cognite-bulldozer[bot] f383282
test: instance delete limitation
toondaey c34e634
test: debug test
toondaey b2f865f
test: limit test threads
toondaey 96c6e73
test: limit test threads
toondaey 9391935
test: retry on deletes
toondaey da408b3
test: increase retry time
toondaey 7c6b0a7
test: manage concurrency attempt v1
toondaey dc5c719
test: refactor tests
toondaey 1b2c26a
style: remove unnecessary
toondaey 1e08a07
feat: with jitters
toondaey e9d9577
refactor: remove unused
toondaey d821ff6
test: apply the breaks
toondaey 8848f20
Merge branch 'master' into cdm-timeseries/dog-4175
toondaey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I find that
Option<bool>
should be avoided. In this case it's better if users just have to pick one, either true or false, leaving it as None as no special semantic meaning beyond "use the default", so if users want to leave them asNone
they have to look up what that means, which means they might as well just set a value.