Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create missing timeseries cdm - dog-4368 #264

Merged
merged 7 commits into from
Oct 14, 2024
Merged

create missing timeseries cdm - dog-4368 #264

merged 7 commits into from
Oct 14, 2024

Conversation

toondaey
Copy link
Contributor

@toondaey toondaey commented Oct 9, 2024 •
edited
Loading

This also includes some DRY optimization.

@toondaey toondaey marked this pull request as ready for review October 13, 2024 17:52
@toondaey toondaey requested a review from a team as a code owner October 13, 2024 17:52
@toondaey toondaey requested a review from mathialo October 13, 2024 17:52
einarmo
einarmo approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@einarmo einarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Nice work.

@toondaey toondaey merged commit 9a75fea into master Oct 14, 2024
2 checks passed
@toondaey toondaey deleted the timeseries-create-missing/dog-4368 branch October 14, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einarmo einarmo einarmo approved these changes

@mathialo mathialo Awaiting requested review from mathialo mathialo is a code owner automatically assigned from cognitedata/rustaceans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toondaey @einarmo