Allow aliases for key vault config #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep consistency with the dotnet variant, let's also allow to configure `key-vault` as an alias for `azure-keyvault` and `key-vault-name` as an alias for `keyvault-name`.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 78.74% 78.72% -0.02%
==========================================
Files 22 22
Lines 1971 1974 +3
==========================================
+ Hits 1552 1554 +2
- Misses 419 420 +1
|
einarmo
reviewed
Jan 19, 2024
Co-authored-by: Einar <[email protected]>
einarmo
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep consistency with the dotnet variant, let's also allow to configure
key-vaultas an alias forazure-keyvaultandkey-vault-nameas an alias forkeyvault-name.