[CDF-24184] 🚍 Strongly coupled views. #1490
Merged
+1,406
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
doctrino
commented
Mar 1, 2025
Comment on lines
-604
to
-605
| elif self._is_deployment_order(e1, set(self.get_ids(items))): | ||
| return self._fallback_create_one_by_one(self._topological_sort(items), e1, warn=False) |
There was a problem hiding this comment.
This is handled by the new method, so we no longer need it.
This was referenced Mar 1, 2025
ronpal
approved these changes
Mar 3, 2025
|
@erlendvollset what do you think here? Something that should be fixed in the API? |
Starbase is already notified, and yes this is definitely something that should be fixed in the API. However, we currently have a customers that is waiting for this fix. So suggest we merge this one, as that will solve the immediate problem. |
BugGambit
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Data models with strongly coupled views through implements and reverse direct relations are tricky to deploy as the API returns 400 complaining about views missing which are part of the request.
Isolating exactly what causes this false
400 + does not existsturned out to be extremely hard, it seem that you need a model of a certain size to trigger this behavior. Ended up using a larger model with lots of coupling to consistently trigger the error.Node The relevant team has been notified, but as we have users waiting for this, I suggest we do merge this PR as soon as possible to have it ready.
Changelog
cdf
Fixed
cdf deployfor highly coupled views, the Toolkit now tries to recover if the API returns 400 withdoes not existsin the error message referencing a view that is part of the request.templates
No changes.