feat(ui-kit): ported toggletip module from Hanami #83
Conversation
| --bg-color: var(--cz-color-white); | ||
| --font-size: 0.875rem; | ||
| position: relative; | ||
| max-width: 23rem; |
There was a problem hiding this comment.
oui :D can't we have this in px? (since we want to use px for width at this moment 🤔 )
There was a problem hiding this comment.
Here it's one of the cases where width in rem makes more sense -> if the user sets a high font size, it's better to leave it some more breathing room, otherwise with a width in px it will feel cramped 😅
| top: 0.25rem; | ||
| right: 0.25rem; | ||
|
|
||
| height: 1.5rem; |
There was a problem hiding this comment.
same as the above statement, px is better I believe
There was a problem hiding this comment.
I changed top and right to px which indeed make more sense, but here since it's about an ico button, I feel it's better to make it bigger if the user sets a higher font size, as it would make the button easier to click on? What do you think? 🤔
There was a problem hiding this comment.
if it works fine for you with higher font sizes, we can keep it as is :)
| selector: 'cz-toggletip', | ||
| template: ` | ||
| <ng-template #tpl> | ||
| <div [id]="dialogId" class="cz-toggletip-content" role="dialog" tabindex="-1"> |
There was a problem hiding this comment.
the [id] can come after class/role etc :)
There was a problem hiding this comment.
Id should alwasy be (almost) first, even if it is dynamic :) https://www.notion.so/cognizone/Angular-c8f02176425644c093b1f7c33bcccae9?pvs=4#b48d5c9b77584d769b9947da69a97703
WilliamChelman
force-pushed
the
feature/toggletip
branch
from
600c324 to
8b6e82c
Compare
No description provided.