Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: tech-debt/move-subscription-side-effect #228

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Draft: tech-debt/move-subscription-side-effect #228

wants to merge 4 commits into from

Conversation

cogwizzle
Copy link
Owner

Moved the side effect code out of the character form observable and into a subscription function so the observable does not have too much responsibility.

Testing:
Form Changes Work

  1. Open a incognito chrome window
  2. Make changes to the form
  3. Reload the page
  4. Ensure the changes are persisted.

Reset Works

  1. Load a character from a file.
  2. Click the reset button.
  3. Ensure the form is empty.

@cogwizzle cogwizzle added the enhancement New feature or request label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cogwizzle