Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report step on CI #1602

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix report step on CI #1602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a12b5c
Fix TPC-H CI
hendrikmakait Nov 14, 2024
2b268ae
Fix CI report
hendrikmakait Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ jobs:
script: |
const workflow_url = `https://github.com/${process.env.GITHUB_REPOSITORY}/actions/runs/${process.env.GITHUB_RUN_ID}`
const issue_body = `[Workflow Run URL](${workflow_url})`
github.issues.create({
github.rest.issues.create({
owner: context.repo.owner,
repo: context.repo.repo,
body: issue_body,
Comment on lines 262 to 268
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to do anything here, but just wanted to note that the original version of this code has been moved into it's own GitHub action https://github.com/xarray-contrib/issue-from-pytest-log which is what we're now using in dask/dask

https://github.com/dask/dask/blob/98331028f8a51d404f8c9856d49ba726322c4e03/.github/workflows/upstream.yml#L76-L86

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this is mostly just an FYI

Expand Down
3 changes: 0 additions & 3 deletions tests/tpch/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ def pytest_addoption(parser):
parser.addoption("--cloud", action="store_false", dest="local", help="")
parser.addoption("--restart", action="store_true", default=True, help="")
parser.addoption("--no-restart", action="store_false", dest="restart", help="")
parser.addoption(
"--performance-report", action="store_true", default=False, help=""
)
parser.addoption(
hendrikmakait marked this conversation as resolved.
Show resolved Hide resolved
"--scale",
action="store",
Expand Down
Loading