Purge dask-expr
#1648
Merged
Purge dask-expr
#1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjetter
reviewed
Jan 9, 2025
| @@ -142,7 +141,6 @@ def tpch_database_table_schema(request, testrun_uid, scale, query, local): | |||
| originalname=request.node.originalname, | |||
| path=str(request.node.path.relative_to(TEST_DIR)), | |||
| dask_version=dask.__version__, | |||
| dask_expr_version=dask_expr.__version__, | |||
There was a problem hiding this comment.
this is a DB change. I'm not sure if any of our CI jobs reacts to this. Technically, this would require a DB migration (but I'm also fine with just setting this to null)
There was a problem hiding this comment.
If I understand correctly, this would just set the TPCHRun.dask_expr_version to None, which is allowed:
benchmarks/benchmark_schema.py
Line 86 in 615ba99
There was a problem hiding this comment.
ok, that's what I wanted. Thanks for checking
fjetter
approved these changes
Jan 16, 2025
phofl
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to dask/dask#11623
Closes #1647
The only thing I haven't purged is the
dask_expr_versioncolumn from the runs.