Skip to content

Commit

Permalink
Add icon to show in listings and folder_contents
Browse files Browse the repository at this point in the history
  • Loading branch information
@frapell
frapell committed Sep 20, 2022
1 parent 82153ef commit 11f5ba4
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/collective/easyform/profiles/default/registry.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,11 @@
interface="collective.easyform.browser.controlpanel.IEasyFormControlPanel"
name="easyform.csv_delimiter"></record>

<record name="plone.icon.contenttype/easyform">
<field type="plone.registry.field.TextLine">
<title>Easyform</title>
</field>
<value key="resource">++plone++bootstrap-icons/ui-checks.svg</value>
</record>

</registry>

4 comments on commit 11f5ba4

@petschki
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This registry record really shouldn't be necessary because the icon is already defined in the FTI here https://github.com/collective/collective.easyform/blob/master/src/collective/easyform/profiles/default/types/EasyForm.xml#L13 ... it is mentioned here, that mockup/portlets/etc. should lookup the FTI icon_expr ... plone/mockup#1159 and plone/plone.app.portlets#163 ... there's also a summary of iconresolver issues here plone/Products.CMFPlone#3500

@frapell
Copy link
Member Author

@frapell frapell commented on 11f5ba4 Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petschki Yeah, that would way better, but I added this because it wasn't doing it for me... maybe it was fixed after I did this commit?

@petschki
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is still an open task.

@frapell
Copy link
Member Author

@frapell frapell commented on 11f5ba4 Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petschki Ahhh got it, yeah, I agree it would be a way better solution that this... I'll try to work on it then if I find some spare time

Please sign in to comment.