Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sign handling in BYDAY #16

Merged
merged 1 commit into from
Sep 20, 2013
Merged

Fixed sign handling in BYDAY #16

merged 1 commit into from
Sep 20, 2013

Conversation

Aridor2006
Copy link
Contributor

The RFC describes weekdaynum as: [[plus / minus] ordwk] weekday.
This commit fixes a bug when the optional sign was missing, by adding a plus, which is required by the orderIndexes.

The RFC describes weekdaynum as: [[plus / minus] ordwk] weekday.
This commit fixes a bug when the optional sign was missing, by adding a plus, which is required by the orderIndexes.
@thet
Copy link
Member

thet commented Aug 30, 2013

hi, can you also provide some unit tests?
or can you provide some more information about what your pull request is fixing? (some test data...)

altough the tests are plagued by heisenbugs (see: #8), with your patch in line there are more failing than before - so someone has to fix some other tests too.

@Aridor2006
Copy link
Contributor Author

Hi, I can't really get the tests to work reliably, probably because of that bug. But take for example the "Trimonthly recurrence by day" test:
"RRULE:FREQ=MONTHLY;INTERVAL=3;BYDAY=+3TH"
should be the same as
"RRULE:FREQ=MONTHLY;INTERVAL=3;BYDAY=3TH".

The second one fails though, which i fixed by adding the + when parsing BYDAY.

@thet thet merged commit 48a4992 into collective:master Sep 20, 2013
@thet
Copy link
Member

thet commented Sep 21, 2013

ok, i'm adding tests...
without this fix, the parsed RRULE string above is finally returned to the textarea as:

RRULE:FREQ=MONTHLY;INTERVAL=3;BYDAY=+1TH

which is wrong and should be:

RRULE:FREQ=MONTHLY;INTERVAL=3;BYDAY=+3TH

@thet
Copy link
Member

thet commented Sep 21, 2013

tests and changelog added here:
54fbe90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants