-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[multiplyMatrices] Update implementation to pass all tests #631
base: main
Are you sure you want to change the base?
[multiplyMatrices] Update implementation to pass all tests #631
Conversation
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think the output generally looks okay to me. The results behave like I would expect. I do find the output in the HTML a bit frustrating as it strips all the brackets (which isn't something you are doing or can control). I would expect the multiplication of |
Is there anything blocking this from being merged? |
I have no objections to anything in the review, though I'm the only one who seems to have reviewed it. |
Updates implementation and passes all tests for
multiplyMatrices
.I attempted to make the smallest changes per commit to pass skipped tests. Once a test was passed, I didn't skip it again (resulting in one regression that was also fixed).
Note: To see that an error is no longer thrown by multiplying empty arrays, you'll have to comment out the
block in the Incorrect Data test when running
htest
.@lloydk, let me know how this looks to you. And I can also fit some refactoring into this pull request before it's merged, if needed.
I wanted to prioritize minimal changes to pass the tests which would make a future refactor easier to understand before I started it.