Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[channel-picker] Preserve previously selected channel #149

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

DmitrySharabin
Copy link
Member

@DmitrySharabin DmitrySharabin commented Nov 12, 2024

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for color-elements ready!

Name Link
🔨 Latest commit ae3872c
🔍 Latest deploy log https://app.netlify.com/sites/color-elements/deploys/673355134d9a910008809cf1
😎 Deploy Preview https://deploy-preview-149--color-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DmitrySharabin DmitrySharabin force-pushed the channel-picker-history branch 3 times, most recently from f97b72c to 7a39f23 Compare November 12, 2024 13:14
Fix optional chaining
Simplify code
Simpler
Oops
Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't think we actually need to be that diligent, even if it didn't check the coord name, it would've been fine

@DmitrySharabin DmitrySharabin merged commit 4817170 into main Nov 12, 2024
4 checks passed
@DmitrySharabin DmitrySharabin deleted the channel-picker-history branch November 12, 2024 22:53
@DmitrySharabin
Copy link
Member Author

LGTM, but I don't think we actually need to be that diligent, even if it didn't check the coord name, it would've been fine

I was guided by your comment in the previous PR. 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants