Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store the first link on an opportunity 🔗 #722

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

ramiAbdou
Copy link
Member

Description ✏️

Instead of having to pull the link out of an opportunity at runtime whenever we want to show it, instead we should just store it on the opportunity itself.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Feb 26, 2025
@ramiAbdou ramiAbdou marked this pull request as ready for review February 26, 2025 23:58
@ramiAbdou ramiAbdou merged commit c6be8fc into main Feb 27, 2025
2 checks passed
@ramiAbdou ramiAbdou deleted the rami/store-link branch February 27, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant