Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filetype selection to save image #6546

Closed

Conversation

evan-holland-873
Copy link

@evan-holland-873 evan-holland-873 commented Jan 21, 2025

#6518
This adds a filetype selection to the Save Image node so you can choose which format output images will be saved as for convenience. I have tested each format and they all work properly. I'm not sure if metadata works, or if there are any concerns with the implementation file = f"{filename_with_batch_num}_{counter:05}_.{file_type}".

Screenshot from 2025-01-21 00-19-25

Screenshot from 2025-01-21 00-24-51

@ltdrdata
Copy link
Collaborator

ltdrdata commented Jan 22, 2025

When adding this feature, it should not only expand the types of files that can be saved but also implement the functionality to save workflows as metadata/exif, allowing them to be loaded on the front end.

FYI,

metadata[inital_exif] = "{}:{}".format(x, json.dumps(extra_pnginfo[x]))

@evan-holland-873
Copy link
Author

@ltdrdata I'm sorry, I don't quite understand. Why should it save workflows, and what are you trying to show me with the SaveAnimatedWEBP line? I closed this because I messed up my fork but I'll open a new one if I'm able to do what you are asking.

@ltdrdata ltdrdata reopened this Jan 22, 2025
@ltdrdata ltdrdata closed this Jan 22, 2025
@ltdrdata
Copy link
Collaborator

@ltdrdata I'm sorry, I don't quite understand. Why should it save workflows, and what are you trying to show me with the SaveAnimatedWEBP line? I closed this because I messed up my fork but I'll open a new one if I'm able to do what you are asking.

ComfyUI supports image/video/audio drag&drop via that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants