Add node for preview 3d animation #6594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtydhr88
requested review from
yoland68,
robinjhuang,
huchenlei,
pythongosssss,
ltdrdata and
Kosinkadink
as code owners
This was referenced Jan 25, 2025
huchenlei
previously approved these changes
Jan 25, 2025
|
@jtydhr88 Can you add a screenshot or video clip on how to use this node? |
|
@huchenlei sure 2025-01-24.22-49-27.mp4this is similiar to Preview 3d (which using in IF_Trellis and Hunyuan3DWrapper now) but support to play FBX/glb animation in the video, the test animation glb file provided by the user from #6583 |
|
made two more changes in this PR, since I move bg color/animation speed button to scene, the bg_color and animation_speed param should be removed, FE change is Comfy-Org/ComfyUI_frontend#2365 |
robinjhuang
approved these changes
Jan 31, 2025
huchenlei
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new preview 3d - animation node to support FBX/glb animation preview, requested in #6583
FE changes is Comfy-Org/ComfyUI_frontend#2341