Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

res_multistep: Fix cfgpp and add ancestral samplers #6731

Merged

Conversation

pamparamm
Copy link
Contributor

Continuation of #6462
This PR:

  • Adds res_multistep_ancestral and res_multistep_ancestral_cfg_pp samplers. Since res_multistep is a modified version of DPM-Solver++, it's quite easy to make it ancestral.
  • Fixes cfg_pp implementation in res_multistep sampler by replacing incorrect denoised with uncond_denoised and setting old_denoised to uncond prediction. This should decrease artifacts even more.

I've also removed some unused parts and simplified the code even more.

@comfyanonymous comfyanonymous merged commit caeb27c into comfyanonymous:master Feb 9, 2025
5 checks passed
@eeditor1055
Copy link

Good day.
I updated ComfyUI (twice) after this commit merge, but still don't have res_multistep_ancestral and it's cfg_pp variant on Ksampler.

@ltdrdata
Copy link
Collaborator

ltdrdata commented Feb 9, 2025

Make sure your ComfyUI is up-to-date.

image

@eeditor1055
Copy link

I run update again. This time it actually updated it. Now I have it. Maybe it was some bug.
Thanks for help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants