fdcan: rate limit CAN core reset #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issues on ignition off with some transmit errors and forced resets!
Before, we would get stuck resetting in a loop for ~500 resets: #2134 (comment) |
adeebshihadeh
approved these changes
Jan 30, 2025
elkoled
pushed a commit
to elkoled/panda
that referenced
this pull request
Feb 18, 2025
* rate limit can core resets * overflow protection * U
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2132 and commaai/openpilot#33840.
Ignition off w/ canState1 and canState2 active receiving messages w/ forced resetting on canState0 (bus 2, similar case to right after ignition off in commaai/openpilot#33840):