Require parameters to have type declarations

commonphp · Feb 17, 2024 · d886e27 · d886e27
1 parent 0be6ae3
commit d886e27
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/Support/ValueFinder.php b/src/Support/ValueFinder.php
@@ -16,6 +16,7 @@
 
 use Closure;
 use CommonPHP\DependencyInjection\Exceptions\ParameterDiscoveryFailedException;
+use CommonPHP\DependencyInjection\Exceptions\ParameterTypeRequiredException;
 use CommonPHP\DependencyInjection\Exceptions\UnsupportedReflectionTypeException;
 use ReflectionFunction;
 use ReflectionMethod;
@@ -115,6 +116,7 @@ public function findValue(string $name, ReflectionType $types, array $passedPara
      * @return array An array of resolved parameters suitable for invoking the function or method.
      * @throws ParameterDiscoveryFailedException
      * @throws UnsupportedReflectionTypeException
+     * @throws ParameterTypeRequiredException
      */
     public function findParameters(ReflectionFunction|ReflectionMethod $source, array $passedParameters): array
     {
@@ -126,6 +128,14 @@ public function findParameters(ReflectionFunction|ReflectionMethod $source, arra
         foreach ($source->getParameters() as $parameter)
         {
             $found = false;
+            if ($parameter->getType() === null)
+            {
+                throw new ParameterTypeRequiredException(
+                    $source instanceof ReflectionMethod ? $source->getDeclaringClass()->getName() : '{main}',
+                    $source->getName(),
+                    $parameter->getName()
+                );
+            }
 
             // Try to find the value
             $newValue = $this->findValue($parameter->getName(), $parameter->getType(), $passedParameters, $found);