Generic Ubuntu VM script #269

irish1986 · 2024-11-15T17:46:38Z

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Create a new generic ubuntu-vm script that allows the user ot select which version of ubuntu should be installed.

Type of change

Please check the relevant option(s):

Bug fix (non-breaking change that resolves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
Testing performed (I have tested my changes, ensuring everything works as expected)
Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

C&C are welcomed via PR comments.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

Related Discussion [Script update] Ubuntu VM #268

Mellowlynx · 2024-11-15T20:09:59Z

I don't see the need for this script, To choose a version I have to go to all the advanced options, there are separate scripts for this reason.
Currently, you run the script of the version you want, not extra options needed.
If the update was just a version question in the standard too, maybe.

havardthom · 2024-11-15T21:59:51Z

Ubuntu focal has end of standard support april 2025, we do not want to add that option now. Oracular is not LTS.

I'm not totally opposed to having one Ubuntu VM script which defaults to noble and with the option to downgrade to jammy in advanced options. This would make it consistent with the Ubuntu LXC (where we should update default version to noble).

This is also a VM script so it should not be a breaking change to existing users.

MickLesk · 2024-11-15T22:02:01Z

This is also a VM script so it should not be a breaking change to existing users.

What is your opinion? I've skimmed through it and am rather against a merge. That's what the advanced settings are for.

havardthom · 2024-11-15T22:10:25Z

vm/ubuntu-vm.sh

@@ -2,17 +2,18 @@

 # Copyright (c) 2021-2024 tteck
 # Author: tteck (tteckster)
+#         irish1986 (irish1986)


Suggested change

# irish1986 (irish1986)

# Co-Author: irish1986 (irish1986)

havardthom · 2024-11-15T22:11:31Z

vm/ubuntu-vm.sh

@@ -21,6 +22,11 @@ echo -e "\n Loading..."
 GEN_MAC=02:$(openssl rand -hex 5 | awk '{print toupper($0)}' | sed 's/\(..\)/\1:/g; s/.$//')
 NEXTID=$(pvesh get /cluster/nextid)

+ORACULAR="oracular"


Suggested change

ORACULAR="oracular"

havardthom · 2024-11-15T22:11:41Z

vm/ubuntu-vm.sh

+ORACULAR="oracular"
+NOBLE="noble"
+JAMMY="jammy"
+FOCAL="focal"


Suggested change

FOCAL="focal"

havardthom · 2024-11-15T22:14:15Z

vm/ubuntu-vm.sh

 }

 function advanced_settings() {
+  if RELEASE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "Ubuntu RELEASE" --radiolist "Choose Version" --cancel-button Exit-Script 10 58 3 \


Suggested change

if RELEASE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "Ubuntu RELEASE" --radiolist "Choose Version" --cancel-button Exit-Script 10 58 3 \

if RELEASE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "UBUNTU VERSION" --radiolist "Choose Version" --cancel-button Exit-Script 10 58 2 \

consistent with LXC

havardthom · 2024-11-15T22:14:41Z

vm/ubuntu-vm.sh

 }

 function advanced_settings() {
+  if RELEASE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "Ubuntu RELEASE" --radiolist "Choose Version" --cancel-button Exit-Script 10 58 3 \
+    "${ORACULAR}" "oracular  " OFF \


Suggested change

"${ORACULAR}" "oracular " OFF \

havardthom · 2024-11-15T22:14:49Z

vm/ubuntu-vm.sh

+    "${ORACULAR}" "oracular  " OFF \
+    "${NOBLE}" "noble  " ON \
+    "${JAMMY}" "jammy  " OFF \
+    "${FOCAL}" "focal  " OFF \


Suggested change

"${FOCAL}" "focal " OFF \

havardthom · 2024-11-15T22:15:26Z

vm/ubuntu-vm.sh

+  if RELEASE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "Ubuntu RELEASE" --radiolist "Choose Version" --cancel-button Exit-Script 10 58 3 \
+    "${ORACULAR}" "oracular  " OFF \
+    "${NOBLE}" "noble  " ON \
+    "${JAMMY}" "jammy  " OFF \


Move jammy option above noble, to be consistent with LXC

havardthom · 2024-11-15T22:16:42Z

vm/ubuntu-vm.sh

 fi
 msg_ok "Completed Successfully!\n"
 echo -e "Setup Cloud-Init before starting \n
-More info at https://github.com/tteck/Proxmox/discussions/2072 \n"
+More info at https://github.com/community-scripts/ProxmoxVE/discussions/268 \n"


Suggested change

More info at https://github.com/community-scripts/ProxmoxVE/discussions/268 \n"

More info at https://github.com/community-scripts/ProxmoxVE/discussions/272 \n"

havardthom · 2024-11-15T22:18:28Z

vm/ubuntu-vm.sh

  VMID="$NEXTID"
  FORMAT=",efitype=4m"
  MACHINE=""
  DISK_CACHE=""
-  HN="ubuntu"
+  HN="ubuntu-${NOBLE}"


What happens to hostname if you choose jammy in advanced settings? you have to manually fix it?

NoirPi · 2024-11-16T07:47:46Z

Hello everyone,

Thank you for the discussion and the proposed changes, especially by @havardthom. I would, however, like to suggest an alternative approach:

Instead of having a single script for multiple versions, I’d prefer keeping separate scripts for each version.
This makes it easier to target the desired version by simply adjusting the URL accordingly, which is at the moment just 2 digits to change:

While I agree that the changes suggested by @havardthom make sense, they further reduce the need for a centralized script, especially since Ubuntu Focal will soon (Yes! 6 month is soon) reach its End of Standard Support and Oracular not being an LTS release.

This would again strip the script down to just 2 versions which is as shown above just a simple 2 digit change in the url.

For this reason, I would suggest not adding a unified script and instead sticking to separate scripts for each version.

havardthom · 2024-11-16T08:16:32Z

Should the Ubuntu LXC also be multiple scripts then? For me both of the approaches works, but we should pick one and be consistent. The approach we choose should also apply to all OS scripts in the future.

NoirPi · 2024-11-16T08:20:28Z

Should the Ubuntu LXC also be multiple scripts then? For me both of the approaches works, but we should pick one and be consistent. The approach we choose should also apply to all OS scripts in the future.

I would definitely suggest that we keep them separated.

The only thing that would be important now and in the future is the naming convention of the scripts themself for all OS Scripts this should also be consistent as you said.

havardthom · 2024-11-16T09:21:44Z

Actually I just remembered that the ability to choose OS version is baked into advanced settings for all LXCs, so the discussion is not applicable there. With that in mind I'm leaning more to having it similar for the vm, with targeting version in advanced settings.

I get the URL point, but you can also argue that having a single URL for ubuntu which does not change every 2 years is more user friendly. Then I can run the same URL every time without having to consider what version I want beforehand, maybe I don't care and just want the recommended/default version. If I do care, I run advanced settings and choose my version, just like an LXC.

In 2026 it would be 3 ubuntu scripts. 3 scripts and 3 documentation sites that need to be considered and synchronized when changes are proposed.

NoirPi · 2024-11-16T09:32:26Z

I understand the argument, but I see it differently. Once I care about the version, I have to go into the advanced settings to select it. Up until now, this hasn’t been necessary.

Now, if we switch to a shared script and the version is only selected through advanced settings, the simple process of creating an Ubuntu 22.04 LXC would be changed.

What could be considered in my opinion is building the consolidated script in such a way that you can directly pass an argument for the version when calling it.

The option with the advanced settings is surely not that bad. But forcing into Advanced Settings to choose the Version, i dont think should be the way to go!

havardthom · 2024-11-16T09:46:12Z

Building a consolidated script would break the established conventions and patterns. Letting the user choose OS version without having to use advanced settings (and without having separate scripts for each version) is something we can consider in the future. As it stands today, all LXCs have OS version choice in advanced settings (like it has always been) and I think VMs should be the same until we choose to make that improvement.

irish1986 added 3 commits November 15, 2024 11:53

feat: add ubunu-vm script

558af81

docs: update discussion thread

91c532f

feat: remove legacy script

9ee4def

irish1986 requested a review from a team as a code owner November 15, 2024 17:46

github-actions bot added breaking change This change is not backward compatible delete script This change deletes a script rename script This change renames a script documentation Improvements or additions to documentation labels Nov 15, 2024

havardthom removed the breaking change This change is not backward compatible label Nov 15, 2024

havardthom reviewed Nov 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generic Ubuntu VM script #269

Generic Ubuntu VM script #269

irish1986 commented Nov 15, 2024 •

edited

Loading

Mellowlynx commented Nov 15, 2024

havardthom commented Nov 15, 2024

MickLesk commented Nov 15, 2024

havardthom Nov 15, 2024

havardthom Nov 15, 2024

havardthom Nov 15, 2024

havardthom Nov 15, 2024

havardthom Nov 15, 2024

havardthom Nov 15, 2024

havardthom Nov 15, 2024

havardthom Nov 15, 2024

havardthom Nov 15, 2024

NoirPi commented Nov 16, 2024

havardthom commented Nov 16, 2024

NoirPi commented Nov 16, 2024

havardthom commented Nov 16, 2024

NoirPi commented Nov 16, 2024

havardthom commented Nov 16, 2024

	if RELEASE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "Ubuntu RELEASE" --radiolist "Choose Version" --cancel-button Exit-Script 10 58 3 \
	if RELEASE=$(whiptail --backtitle "Proxmox VE Helper Scripts" --title "UBUNTU VERSION" --radiolist "Choose Version" --cancel-button Exit-Script 10 58 2 \

	More info at https://github.com/community-scripts/ProxmoxVE/discussions/268 \n"
	More info at https://github.com/community-scripts/ProxmoxVE/discussions/272 \n"

Generic Ubuntu VM script #269

Are you sure you want to change the base?

Generic Ubuntu VM script #269

Conversation

irish1986 commented Nov 15, 2024 • edited Loading

Description

Type of change

Prerequisites

Additional Information (optional)

Related Pull Requests / Discussions

Mellowlynx commented Nov 15, 2024

havardthom commented Nov 15, 2024

MickLesk commented Nov 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NoirPi commented Nov 16, 2024

havardthom commented Nov 16, 2024

NoirPi commented Nov 16, 2024

havardthom commented Nov 16, 2024

NoirPi commented Nov 16, 2024

havardthom commented Nov 16, 2024

irish1986 commented Nov 15, 2024 •

edited

Loading