Skip to content

Commit

Permalink
fixed plugin not called in NurbsSurface
Browse files Browse the repository at this point in the history
  • Loading branch information
chenkasirer committed Jan 6, 2025
1 parent 3b38816 commit 9c283c6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

* Fixed `NotImplementedError` when calling `compas_rhino.conversions.surface_to_compas` on NURBS Surface.

### Removed


Expand Down
2 changes: 1 addition & 1 deletion src/compas/geometry/surfaces/nurbs.py
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ def from_native(cls, surface):
:class:`compas.geometry.NurbsSurface`
"""
raise NotImplementedError
return nurbssurface_from_native(cls, surface)

Check warning on line 395 in src/compas/geometry/surfaces/nurbs.py

View check run for this annotation

Codecov / codecov/patch

src/compas/geometry/surfaces/nurbs.py#L395

Added line #L395 was not covered by tests

@classmethod
def from_parameters(
Expand Down

0 comments on commit 9c283c6

Please sign in to comment.