Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mesh_to_compas returning empty Mesh #1212

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Conversation

chenkasirer
Copy link
Member

@chenkasirer chenkasirer commented Nov 15, 2023

Fixed mesh_to_compas returning an empty Mesh when colors and/or face normals are missing.

Reported by @jckenny59. When attempting to convert a GH mesh to compas one got a Mesh with no vertices or faces.

from compas_rhino.conversions import  mesh_to_compas
import Rhino.Geometry as rg

joint_mesh = rg.Mesh()
mesh = rg.Mesh.CreateFromBrep(brep.native_brep, rg.MeshingParameters.Minimal)
joint_mesh.Append(mesh)

compas_mesh = mesh_to_compas(joint_mesh)
print(compas_mesh)

Would result in

<Mesh with 0 vertices, 0 faces, 0 edges>

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

)

if not rhinomesh.FaceNormals:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we not do it the other way around? if the normals are not there, don't store them?

@tomvanmele tomvanmele merged commit 97608e7 into main Nov 16, 2023
12 checks passed
@chenkasirer chenkasirer deleted the bugfix/mesh_to_compas branch November 16, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants