-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rhino brep slice #1233
Rhino brep slice #1233
Conversation
src/compas/geometry/brep/brep.py
Outdated
|
||
Parameters | ||
---------- | ||
trimming_plane : :class:`~compas.geometry.Frame` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just a plane?
if isinstance(plane, Frame): | ||
plane = Plane.from_frame(plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason why trimming converts a plane to a frame, and slicing converts a frame to a plane?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally random. but changed in trimmed
as makes more sense to eventually use Plane
..
Added
RhinoBrep.slice()
andRhinoBrep.trimmed()
.Changed signature of
Brep.slice()
to returncompas.geometry.Curve
instead ofBrepFace
.@tomvanmele this isn't quite what we discussed, but in Rhino a Brep with no surfaces is not valid.
BrepFace
and other Brep components all don't have public constructors so I don't see a way to return a face either :/Let me know what you think.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).compas.datastructures.Mesh
.