Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhino brep slice #1233

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Rhino brep slice #1233

merged 8 commits into from
Dec 21, 2023

Conversation

chenkasirer
Copy link
Member

@chenkasirer chenkasirer commented Dec 20, 2023

Added RhinoBrep.slice() and RhinoBrep.trimmed().

Changed signature of Brep.slice() to return compas.geometry.Curve instead of BrepFace.

@tomvanmele this isn't quite what we discussed, but in Rhino a Brep with no surfaces is not valid. BrepFace and other Brep components all don't have public constructors so I don't see a way to return a face either :/
Let me know what you think.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)


Parameters
----------
trimming_plane : :class:`~compas.geometry.Frame`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just a plane?

Comment on lines +483 to +484
if isinstance(plane, Frame):
plane = Plane.from_frame(plane)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why trimming converts a plane to a frame, and slicing converts a frame to a plane?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally random. but changed in trimmed as makes more sense to eventually use Plane..

@chenkasirer chenkasirer merged commit 10c8611 into main Dec 21, 2023
12 checks passed
@chenkasirer chenkasirer deleted the rhino_brep_slice branch December 21, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants