Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed compas_rhino.install v8 flag #1423

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removed compas_rhino.install v8 flag #1423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaa2be4
removed the v8.0 flag from compas_rhino.install
chenkasirer Jan 16, 2025
5f3fc63
updated changelog
chenkasirer Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

* Deprecated the `-v8.0` flag in `compas_rhino.install`. Install to Rhino8 by following: https://compas.dev/compas/latest/userguide/cad.rhino8.html.

### Removed


Expand Down
5 changes: 2 additions & 3 deletions src/compas_rhino/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def install(version=None, packages=None, clean=False):

Parameters
----------
version : {'5.0', '6.0', '7.0', '8.0'}, optional
version : {'5.0', '6.0', '7.0'}, optional
The version number of Rhino.
Default is ``'7.0'``.
packages : list of str, optional
Expand Down Expand Up @@ -47,9 +47,8 @@ def install(version=None, packages=None, clean=False):
# instead of directly as IPy module.
# scripts_path = compas_rhino._get_rhino_scripts_path(version)

# In Rhino 8 there is no scripts folder
if version == "8.0":
installation_path = compas_rhino._get_default_rhino_ironpython_sitepackages_path(version)
raise ValueError("Installing to Rhino8 using this script is no longer supported. See https://compas.dev/compas/latest/userguide/cad.rhino8.html")
else:
installation_path = compas_rhino._get_rhino_scripts_path(version)

Expand Down
Loading