Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve class object's type using Cppyy::GetActualClass #71

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

Vipul-Cariappa
Copy link
Collaborator

Copy link
Collaborator

@aaronj0 aaronj0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vipul-Cariappa
Copy link
Collaborator Author

Hi @aaronj0, didn't we drop support to clang-repl 16?
The failing tests are from clang-repl 16.

@Vipul-Cariappa
Copy link
Collaborator Author

Vipul-Cariappa commented Jan 18, 2025

I see that we have dropped clang 16 at
cppyy-backend compiler-research/cppyy-backend@29ff5f0
and
cppyy compiler-research/cppyy@8350aa0

However, I do not see a similar commit in this repo.
Do I remove the clang-repl-16 CI workflows?

EDIT
Also at CppInterOp compiler-research/CppInterOp@a4e908e

@aaronj0
Copy link
Collaborator

aaronj0 commented Jan 19, 2025

I see that we have dropped clang 16 at cppyy-backend compiler-research/cppyy-backend@29ff5f0 and cppyy compiler-research/cppyy@8350aa0

However, I do not see a similar commit in this repo. Do I remove the clang-repl-16 CI workflows?

EDIT Also at CppInterOp compiler-research/CppInterOp@a4e908e

Should be fixed by #72
We can go ahead and merge this now, as the remaining jobs are green

@aaronj0 aaronj0 merged commit 45ebc49 into compiler-research:master Jan 19, 2025
12 of 15 checks passed
Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Jan 19, 2025
Vipul-Cariappa added a commit to Vipul-Cariappa/cppyy-compiler-research that referenced this pull request Jan 19, 2025
Vipul-Cariappa added a commit to compiler-research/cppyy that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants