Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port protocol-validation #78

Open
wants to merge 65 commits into
base: main
Choose a base branch
from
Open

Port protocol-validation #78

wants to merge 65 commits into from

Conversation

buckhalt
Copy link
Member

@buckhalt buckhalt commented Feb 5, 2025 •
edited
Loading

WIP

Todo:

  • reconcile duplicated util (ensureError) from Fresco. this is also in analytics package
  • fix biome linting issues
  • ignore compiled schemas from linting?
  • move over validateExternalData utils
  • export methods that Architect needs
  • errToString
  • getVariableNamesFromNetwork
  • getMigrationNotes
  • canUpgrade
  • migrateProtocol
  • validateNames
  • move unzipping to consumer
  • create test using test-protocols repo
  • update readme
  • implement changesets to manage versioning
  • automatic release publishing with a github workflow
  • rework compiling. either have the build script compile the schemas, or bundle the json/zod schemas and validate against those

@buckhalt
copy paste protocol-validation
bc30f32 
src from fresco, config from protocol-validation repo
@vercel Vercel
Copy link

vercel bot commented Feb 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analytics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 7:59pm
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 7:59pm

@buckhalt buckhalt changed the base branch from main to port-fresco February 5, 2025 16:46
@buckhalt buckhalt changed the base branch from port-fresco to main February 5, 2025 17:12
@jthrilly jthrilly marked this pull request as ready for review February 13, 2025 13:19
@buckhalt
create changeset, add publish workflow
444be8b 
manually revert package version since it will be automatically bumped with changesets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthrilly jthrilly jthrilly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buckhalt @jthrilly