-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pin for boost #1462
Update pin for boost #1462
Conversation
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/boost and so here I am doing that. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to change macOS to use C++ 17 by default as part of this?
Last time we had agreed on doing the boost migration for old and new version at the same time. I have updated it accordingly. Reading conda-forge/clang-compiler-activation-feedstock#17 (comment) I'm not sure whether this would work and whether we failed to do the right thing in the boost update as we didn't increase the C++ standard over there. |
We could mark the |
As noted in the other thread, added the C++17 issue to the agenda for the meeting tomorrow |
conda-forge/clang-compiler-activation-feedstock#75 is in, so this should be unblocked now? |
Shall we jump ahead to 1.78 now? |
The feedstock is on 1.79.0. Would suggest going to that given there are other fixes that have been made to that and not prior releases |
We only migrate even versions and have been only doing that for a while. |
boost migrations tend to be very slow, reveal tons of breaks and bugs, and require lots of person power. |
Understand the need to do fewer migrations. Hence suggesting to go ahead with the newest version Indeed we have had a convention of using even versions. However given it has been a while since we have updated Boost and we are planning to jump ahead. Would push for latest with needed fixes over following a convention that might not be best serving us in this instance |
Agreed (edit 1.80 is almost out, so it's not like we'd be jumping to the very cutting edge with 1.78...) |
Do you know when 1.80.0 is due? |
Based on the patterns of previous releases in about 2 weeks. But I wouldn't go to 1.80 directly (basically no upstream will have tested compat yet, exacerbating the problems Matthew mentioned) - IMO 1.78 is safer. |
I think going to 1.78 makes sense. Is there anything blocking us from doing that in #2757 ? |
Any updates here @conda-forge/boost ? We need #2757 for rstudio updates. |
@conda-forge/core I would really appreciate an update here, we need |
It looks like there is some consensus around going with 1.78. Can we go ahead and merge #2757 ? |
closing since we went with 1.78.0 |
This PR has been triggered in an effort to update the pin for boost. The current pinned version is 1.74.0, the latest available version is 1.76.0 and the max pin pattern is x.x.x. This migration will impact 78 feedstocks.
Checklist:
**Please note that if you close this PR we presume that the new pin has been rejected.
@conda-forge-admin please ping boost
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/808040834, please use this URL for debugging