-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for metis511 #91
Rebuild for metis511 #91
Conversation
…nda-forge-pinning 2023.11.09.20.47.34
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hello everyone, |
@vijaysm, @iulian787, @gonuke and @scopatz, is there any reason not to merge this and migrate to Metis 5.1.1? Unless you are aware of places we will run into the issue that @traversaro mentions above, it seems like we should migrate. |
Just for full alignment, other feedstocks are experiencing problems with metis 5.1.1, even if we did not isolated the specific problems: |
Sorry, I confused this with 5.2.x versions, where we had some build issues. Metis 5.2.x splits the GKlib into its own subrepository. This meant that -lGKlib had to be propagated separately to get linking working in some configurations. We already use 5.1.0 without any issues. I think 5.1.1 upgrade may be fine if needed to simplify the recipe, though I can't find the change history for this version anywhere to confirm whether it would break anything on other architectures. |
Maybe given that other packages are having trouble with metis 5.1.1 and we don't have anyone waiting on this migration downstream (https://conda-forge.org/status/#metis511), we can just put this in draft mode and ignore it? |
Sounds good. My workstation has Metis 5.1.0 and it works well for all relevant usecases. I will try installing 5.1.1 to see if there are regressions, before we decide on this merge. |
I guess we can now close the PR, as the migration to metis 5.1.1 was halted due to upstream problems in metis 5.1.1, see conda-forge/mumps-feedstock#106, conda-forge/conda-forge-pinning-feedstock#5396 and conda-forge/conda-forge-pinning-feedstock#5397 . @minrk |
Thanks for the update @traversaro |
Thanks |
This PR has been triggered in an effort to update metis511.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6817418283, please use this URL for debugging.