-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for flang 19 #16
Rebuild for flang 19 #16
Conversation
TL;DR: We are trying to switch our Fortran compilers on windows to flang. This is not 100% guaranteed to work, but should be fine in the majority of cases. The new LLVM-based flang has become mature enough that it should be possible to broadly switch over our Fortran compilers on windows to it (until now we only had an ancient pre-LLVM flang 5, or alternatively the GCC-based `m2w64_fortran`). As such, this PR attempts to homogenize any use of `m2w64_fortran` and other `m2w64_*` compilers to our default stack (which would then be MSVC + flang on windows), with the exception of feedstocks for R-packages, which stay on the `m2w64_` compilers. Recipes that have hard-coded expectations about the name of the fortran compiler will need to adjust to use `%FC%` or `flang-new` for the compiler name. Similarly, you may need to change the linker to `%LD%` or use `lld-link`. It is also possible that you run into compilation errors due to differences in compiler behaviour, bugs or as-yet unimplemented features. In case of compilation errors due to stricter default language standards, you should be able to fix things by passing `-std=legacy` to `FFLAGS`. If you have problems with this PR, feel free to ping the @c-f/flang-activation team. In case you have convinced yourself that flang really is not ready yet to be used to compile a given feedstock, you may also close this migrator PR.
…onda-forge-pinning 2024.12.17.11.10.14
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
The main Windows build problem is the need for dllexport preprocessor commands for symbols in shared libraries to be detected. Some of the symbols exposed by this procedure ( There are also some weird compiler warnings about inconsistent implicit subroutine interfaces, but they are probably benign. |
I'm looking at this Windows symbol export problem again, and the dllexport bug was reported and fixed in the flang compiler project that is distinct from the flang being developed as part of LLVM, which is the version that condo-forge is using. I see no reference to "dllexport" in the source code for LLVM flang, so maybe it doesn't support that method of exporting DLL symbols on Windows. I'll try to make some inquiries on how this should be done with LLVM flang. A symbol definition file ( |
Does LLVMFlang have any way of exporting DLL symbols? Other Fortran compilers on Windows (including non-LLVM flang) support pre-processor commands like @conda-forge/flang-activation |
Interesting question! I don't know of explicit annotations in Fortran that do something equivalent to
The flang in llvm and the flang from https://github.com/flang-compiler is developed by a largely overlapping set of people, and basically all development moved to llvm-flang now. So if the issue you found still persists with clang, it would probably help to search the issues in https://github.com/llvm/llvm-project, and open a new one (referring to the old one) if there's nothing there. |
Seems like the spglib build skips the DLL on Windows: https://github.com/conda-forge/spglib-feedstock/blob/c71988335977a13eec6e8d884d0f0c99ae2c7b30/recipe/bld.bat#L4 |
Ok, I didn't find any relevant open issues for LLVM flang and just posted one. I'm probably going to release another version of MOPAC before this flang migration resolves, and I plan to add C bindings to all symbols that are intended to be visible (most already have C bindings, so binding the rest is a relatively minor change). The C bindings might help with this symbol export issue, since the symbols won't be compiler-dependent anymore. |
Ok, there is a new MOPAC release with changes that will hopefully improve LLVM Flang support. MOPAC now builds and passes all tests on Linux with LLVM Flang, although I need to increase the stack size for one test that is causing a stack overflow. I've also examined OpenBLAS's build system, which seems to be building on conda-forge with LLVM Flang on Windows, and I've added the CMake command that they used to force symbol exports on Windows. @conda-forge-admin, please rerun bot |
Due to the This message was generated by https://github.com/regro/cf-scripts/actions/runs/13203942279 - please use this URL for debugging. |
This PR has been triggered in an effort to update flang19.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
Here are some more details about this specific migrator:
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12372753219 - please use this URL for debugging.