-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ragatouille
#29342
base: main
Are you sure you want to change the base?
add ragatouille
#29342
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, ready for review! |
recipes/ragatouille/recipe.yaml
Outdated
python_version: ${{ python_min }} | ||
imports: | ||
- ragatouille | ||
pip_check: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? This will force all downstream packages to disable it too. If there is a problem that we can fix, let's fix it. If not, we should document the problem and open an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. The original reason was:
│ │ colbert-ai 0.2.21 requires git-python, which is not installed.
│ │ colbert-ai 0.2.21 requires ninja, which is not installed.
which errors even though I provided them as run dependencies in the colbert-ai-feedstock
:
For git-python
, I'm not sure whether gitpython
is a drop-in replacement:
But the git-python
on pypi looks sketchy:
https://pypi.org/project/git-python/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open an issue in https://github.com/conda-forge/colbert-ai-feedstock/blob/main/recipe/recipe.yaml#L41 about that? Also, please add a comment here so we don't forget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just created that feedstock myself last week. Happy to fix that but do you have an idea how? Ninja is a run dependency and I'm not quite sure what to do about git-python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix what you can and open issues/notes for the rest. The git-python vs gitpython probably need some metadata fix upstream, not only the recipe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I fixed the issues related to colbert-ai
:
conda-forge/colbert-ai-feedstock#1
- gitpython is incorrectly required by upstream (PR to fix upstream here, I patched it in the feedstock)
ninja
is required becausecolbert-ai
usestorch
's ability to load and JIT cpp modules (see here) but since theninja
package only contains a ninja binary inbin/ninja
it fails the pip check
Last problem is faiss-cpu
as a direct dependency. Could this be a similar problem where the package is not recognized as a python package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last problem is
faiss-cpu
as a direct dependency. Could this be a similar problem where the package is not recognized as a python package?
No idea. Sorry, my packages are usually quite "vanilla pure python." If that is the case we should add a comment about it and skip pip-check for now.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).