Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ragatouille #29342

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

moritzwilksch
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ragatouille/recipe.yaml) and found it was in an excellent condition.

@moritzwilksch
Copy link
Member Author

@conda-forge/help-python, ready for review!

python_version: ${{ python_min }}
imports:
- ragatouille
pip_check: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This will force all downstream packages to disable it too. If there is a problem that we can fix, let's fix it. If not, we should document the problem and open an issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. The original reason was:

 │ │ colbert-ai 0.2.21 requires git-python, which is not installed.
 │ │ colbert-ai 0.2.21 requires ninja, which is not installed.

which errors even though I provided them as run dependencies in the colbert-ai-feedstock:

https://github.com/conda-forge/colbert-ai-feedstock/blob/a76ce8c4437fdf05cf1e81f36777ead2745f2169/recipe/recipe.yaml#L27-L29

For git-python, I'm not sure whether gitpython is a drop-in replacement:

https://github.com/stanford-futuredata/ColBERT/blob/7067ef598b5011edaa1f4a731a2c269dbac864e4/setup.py#L25

But the git-python on pypi looks sketchy:
https://pypi.org/project/git-python/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue in https://github.com/conda-forge/colbert-ai-feedstock/blob/main/recipe/recipe.yaml#L41 about that? Also, please add a comment here so we don't forget.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created that feedstock myself last week. Happy to fix that but do you have an idea how? Ninja is a run dependency and I'm not quite sure what to do about git-python

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix what you can and open issues/notes for the rest. The git-python vs gitpython probably need some metadata fix upstream, not only the recipe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I fixed the issues related to colbert-ai:
conda-forge/colbert-ai-feedstock#1

  • gitpython is incorrectly required by upstream (PR to fix upstream here, I patched it in the feedstock)
  • ninja is required because colbert-ai uses torch's ability to load and JIT cpp modules (see here) but since the ninja package only contains a ninja binary in bin/ninja it fails the pip check

Last problem is faiss-cpu as a direct dependency. Could this be a similar problem where the package is not recognized as a python package?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last problem is faiss-cpu as a direct dependency. Could this be a similar problem where the package is not recognized as a python package?

No idea. Sorry, my packages are usually quite "vanilla pure python." If that is the case we should add a comment about it and skip pip-check for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants