Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var setting to disable ssl verification for user journey tests #1040

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Jan 8, 2025

Description

This PR adds an option when running user journey tests to disable SSL verification. This is useful when running tests against a host that has ssl enabled but is does not have valid certs (eg. using self signed certs).

In order to disable SSL verification in the user journey tests, set the env var CONDA_STORE_TEST_VERIFY_SSL=0. By default, SSL verification will be enabled.

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit fec8f2c
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/6780359574f62b0008107d5d

@soapy1 soapy1 force-pushed the dont-verify-ssl-in-tests branch from 1a20679 to 5196f45 Compare January 8, 2025 19:13
@soapy1
Copy link
Contributor Author

soapy1 commented Jan 8, 2025

The failing test is unrelated to these changes and is resolved in #1041

@peytondmurray
Copy link
Contributor

Related: nebari-dev/nebari#2895

Nebari runs tests against their conda-store deployment. In their test environment, conda-store is accessed over https, but does not have valid certs.

Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it'll be useful for the nebari team :)

@soapy1 soapy1 merged commit c79cffd into conda-incubator:main Jan 14, 2025
30 checks passed
@soapy1 soapy1 deleted the dont-verify-ssl-in-tests branch January 14, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants