Fix user-journey tests for running against non-default targets #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conda-store ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
soapy1
force-pushed
the
fix-ssl-verify-test-check
branch
2 times, most recently
from
5bd0b5e to
ed8ef93
Compare
soapy1
force-pushed
the
fix-ssl-verify-test-check
branch
from
ed8ef93 to
2599844
Compare
soapy1
changed the title
soapy1
force-pushed
the
fix-ssl-verify-test-check
branch
2 times, most recently
from
4845702 to
4ba3ea9
Compare
8 tasks
peytondmurray
approved these changes
Jan 23, 2025
Comment on lines
+32
to
+33
| verify = os.environ.get("CONDA_STORE_TEST_VERIFY_SSL", "true") | ||
| return verify.lower() not in ("0", "false") |
| @@ -136,7 +134,7 @@ def create_token( | |||
| """Create a token with a specified role in a specified namespace.""" | |||
| json_data = { | |||
| "primary_namespace": default_namespace, | |||
| "expiration": time_utils.get_iso8601_time(1), | |||
| # "expiration": time_utils.get_iso8601_time(1), | |||
There was a problem hiding this comment.
Hmm, I thought we needed an expiration time? If we don't, let's just remove this line.
There was a problem hiding this comment.
Nope, by default the api will set the expiry to the same expiration as the token that is making the request.
This line in particular was not generating the expiration in the right format so it was causing an error. By removing this line the generated token will get the default expiration value.
soapy1
force-pushed
the
fix-ssl-verify-test-check
branch
from
281147a to
c34e7c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a variety of fixes to the user journey tests in order to run them against non default targets (eg. like nebari's conda store deployment). This is required for nebari-dev/nebari#2895
Fix
CONDA_STORE_TEST_VERIFY_SSLPreviously setting any value for
CONDA_STORE_TEST_VERIFY_SSLresulted in enabling ssl verification. So, settingCONDA_STORE_TEST_VERIFY_SSL=0orCONDA_STORE_TEST_VERIFY_SSL=falseenabled ssl verification. This is because strings are truthy.This PR fixes this by checking if the passed in env var is one of
0,falseorFalsein order to determine if tests should verify SSL.Use
CONDA_STORE_TOKENPreviously all but one conda-store user journey tests used the
CONDA_STORE_TOKENas auth when running tests. This PR extends this so that all user journey tests can use the provided auth token for auth.Ensure new api contexts are valid
Previously, some tests created new utils.API instances. However, the generated tokens had invalid expiry values and did not respect the SSL settings.
Pull request checklist