Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo migration to remove redundant channel column #1071

Merged

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Jan 30, 2025

Fixes #1070

Description

undoes: https://github.com/conda-incubator/conda-store/pull/1010/files

unfixes: #994

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit 4cc5510
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/679c101733c9c400084b306d

@soapy1 soapy1 marked this pull request as ready for review January 31, 2025 00:31
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked by hand that there were no (significant) differences between orm.py and test_orm.py between this branch and 3250928. Not sure why git revert wasn't happy, but this effectively does the right thing anyway.

@soapy1 soapy1 merged commit c711b03 into conda-incubator:main Jan 31, 2025
30 checks passed
@soapy1 soapy1 deleted the undo-remove-redundant-channel-migration branch January 31, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Duplicate key validation error on conda-store-server
2 participants