Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adapt shell init for mamba 2 #914

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

jjerphan
Copy link
Contributor

@jjerphan jjerphan commented Dec 16, 2024

Description

Fix conda-forge/miniforge#697.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

I am interested to have some guidance on the best way to test it.

@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @jjerphan.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1078), and ping the bot to refresh the PR.

@travishathaway
Copy link
Contributor

@conda-bot check

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 16, 2024
@jjerphan jjerphan marked this pull request as ready for review December 17, 2024 10:11
@jjerphan jjerphan requested a review from a team as a code owner December 17, 2024 10:11
jjerphan and others added 4 commits January 10, 2025 16:29
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the fix/shell-init-on-mamba-2 branch from 53b95a8 to 5976c35 Compare January 10, 2025 15:40
@jaimergp
Copy link
Contributor

I think you'll probably want some mamba specific tests in https://github.com/jjerphan/constructor/blob/fix/shell-init-on-mamba-2/examples/miniforge/test_install.sh.

Signed-off-by: Julien Jerphanion <[email protected]>

Co-authored-by: jaimergp <[email protected]>
@jaimergp jaimergp merged commit 4b35ca7 into conda:main Jan 10, 2025
16 checks passed
@jaimergp
Copy link
Contributor

Thanks!

@jjerphan
Copy link
Contributor Author

Thank you for the guidance and the responsiveness.

@jjerphan jjerphan deleted the fix/shell-init-on-mamba-2 branch January 10, 2025 18:17
@jjerphan
Copy link
Contributor Author

@hmaarrfk: should we redo a PR on Miniforge to use 2.0.5 adding tests there for the installation on all platforms once a new version of constructor is released?

@hmaarrfk
Copy link
Contributor

yes that would be great!

@jjerphan
Copy link
Contributor Author

@jaimergp: how can we help with a new release of constructor?

@jaimergp
Copy link
Contributor

We have a few items in the news/ dir, so we can try to cut something next week! WDYT @marcoesters? Are you planning any other PRs soon that would require waiting?

@marcoesters
Copy link
Contributor

marcoesters commented Jan 10, 2025

I think we should create a patch release for sure because of #922 at least. We can cut a release on Monday.

@jjerphan
Copy link
Contributor Author

FYI, I am using now an installation of miniforge from the generated shell script without any problem.

I think it would help to add test on conda-forge/miniforge for all supported platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏁 Done
6 participants