properly destroy dropdown

conestack · Feb 24, 2025 · ee23232 · ee23232
1 parent 2f41222
commit ee23232
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 5 deletions.
diff --git a/js/src/default/widget.js b/js/src/default/widget.js
@@ -57,6 +57,10 @@ export class AutocompleteSuggestion {
         this.selected = true;
         this.widget.select_suggestion(this.id, this.value);
     }
+
+    destroy() {
+        this.elem.off('mousedown', this.select);
+    }
 }
 
 export class AutocompleteWidget {
@@ -126,11 +130,14 @@ export class AutocompleteWidget {
 
     destroy() {
         clearTimeout(this.timeout);
-        this.dd_elem.remove();
+        for (let suggestion of this.suggestions) {
+            suggestion.destroy();
+        }
         this.input_elem
             .off('focusout', this.hide_dropdown)
             .off('focus input', this.on_input)
             .off('keydown', this.on_keydown);
+        this.dd_elem.off().empty().remove();
     }
 
     parse_source() {

diff --git a/src/yafowil/widget/autocomplete/resources/bootstrap5/widget.js b/src/yafowil/widget/autocomplete/resources/bootstrap5/widget.js
@@ -51,6 +51,9 @@ var yafowil_autocomplete = (function (exports, $) {
             this.selected = true;
             this.widget.select_suggestion(this.id, this.value);
         }
+        destroy() {
+            this.elem.off('mousedown', this.select);
+        }
     }
     class AutocompleteWidget$1 {
         static initialize(context) {
@@ -108,11 +111,14 @@ var yafowil_autocomplete = (function (exports, $) {
         }
         destroy() {
             clearTimeout(this.timeout);
-            this.dd_elem.remove();
+            for (let suggestion of this.suggestions) {
+                suggestion.destroy();
+            }
             this.input_elem
                 .off('focusout', this.hide_dropdown)
                 .off('focus input', this.on_input)
                 .off('keydown', this.on_keydown);
+            this.dd_elem.off().empty().remove();
         }
         parse_source() {
             const source = this.input_elem.data('source');

diff --git a/src/yafowil/widget/autocomplete/resources/bootstrap5/widget.min.js b/src/yafowil/widget/autocomplete/resources/bootstrap5/widget.min.js
diff --git a/src/yafowil/widget/autocomplete/resources/default/widget.js b/src/yafowil/widget/autocomplete/resources/default/widget.js
@@ -51,6 +51,9 @@ var yafowil_autocomplete = (function (exports, $) {
             this.selected = true;
             this.widget.select_suggestion(this.id, this.value);
         }
+        destroy() {
+            this.elem.off('mousedown', this.select);
+        }
     }
     class AutocompleteWidget {
         static initialize(context) {
@@ -108,11 +111,14 @@ var yafowil_autocomplete = (function (exports, $) {
         }
         destroy() {
             clearTimeout(this.timeout);
-            this.dd_elem.remove();
+            for (let suggestion of this.suggestions) {
+                suggestion.destroy();
+            }
             this.input_elem
                 .off('focusout', this.hide_dropdown)
                 .off('focus input', this.on_input)
                 .off('keydown', this.on_keydown);
+            this.dd_elem.off().empty().remove();
         }
         parse_source() {
             const source = this.input_elem.data('source');