tests/e2e: Skip tests after analysis #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based in the test analysis done for 18 days of nighty tests in confidential-containers#1831 (comment) the only containerd test failures we saw were: - `TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithImageOnly` - three times - `TestLibvirtCreatePeerPodAndCheckWorkDirLogs` - four times - `TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithDeploymentOnly` - twice Although the chances of failure for each of these tests is < 25%, we want to reduce the re-runs required, so if we skip these we should have more stable CI tests. It should also be noted that most of the failures were seen on the packer built images. This is probably just chance, but might indicate that the peer pod boot speed is related and we should re-evaluate again once we can remove the packer podvm images. Signed-off-by: stevenhorsman <[email protected]>
mkulke
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based in the test analysis done for 18 days of nighty tests in #1831 (comment) the only containerd test failures we saw were:
TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithImageOnly- three timesTestLibvirtCreatePeerPodAndCheckWorkDirLogs- four timesTestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithDeploymentOnly- twiceAlthough the chances of failure for each of these tests is < 25%, we want to reduce the re-runs required, so if we skip these we should have more stable CI tests. It should also be noted that most of the failures were seen on the packer built images. This is probably just chance, but might indicate that the peer pod boot speed is related and we should re-evaluate again once we can remove the packer podvm images.