ci: add delay on podvm smoke-test #2269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhorsman
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
The code looks fine, DCO sign off is expecting [email protected], so failing though
1s delay between claiming an IP address and launching kata-agent is not enough in some cases, resulting in a flaky test. Changing the delay before attempting to connect to the agent to 5s seems to resolve the issue. Running the test in a loop with 25+ launches didn't produce a failure, while doing the same with the original 1s delay, will result in "connection refused" failure after a couple of runs. Signed-off-by: Magnus Kulke <[email protected]>
mkulke
force-pushed
the
mkulke/fix-smoketest-flakyness
branch
from
b0bc946 to
49e6f5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1s delay between claiming an IP address and launching kata-agent is not enough in some cases, resulting in a flaky test.
Changing the delay before attempting to connect to the agent to 5s seems to resolve the issue. Running the test in a loop with 25+ launches didn't produce a failure, while doing the same with the original 1s delay, will result in "connection refused" failure after a couple of runs.