Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attestation-agent: add az-tdx-vtpm attester #375

Merged

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Oct 16, 2023

This attester is supposed to procure evidence from Azure TDX CVMs.. The attester uses a flow similar to the az_snp_vtpm module, albeit with TDX Quotes.

@mkulke mkulke force-pushed the mkulke/add-az-tdx-vtpm-attester branch 2 times, most recently from 4ff635d to 9ad8762 Compare October 18, 2023 07:16
@mkulke mkulke force-pushed the mkulke/add-az-tdx-vtpm-attester branch 2 times, most recently from 0d0afab to 9285caa Compare October 19, 2023 06:48
@mkulke mkulke force-pushed the mkulke/add-az-tdx-vtpm-attester branch 3 times, most recently from f478986 to ce1fad8 Compare October 21, 2023 07:50
@mkulke mkulke force-pushed the mkulke/add-az-tdx-vtpm-attester branch 6 times, most recently from d5bf5b6 to b1c478b Compare November 30, 2023 12:07
@mkulke mkulke changed the title Add az-tdx-vtpm attester attestation-agent: add az-tdx-vtpm attester Nov 30, 2023
@mkulke mkulke marked this pull request as ready for review November 30, 2023 12:09
@mkulke mkulke requested review from jialez0 and sameo as code owners November 30, 2023 12:09
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a small comment for dep version

Cargo.toml Outdated Show resolved Hide resolved
This attester is supposed to procure evidence from Azure TDX CVMs The
attester uses a flow similar to the az_snp_vtpm module, albeit with
TDX Quotes.

Co-authored-by: Iago López Galeiras <[email protected]>

Signed-off-by: Magnus Kulke <[email protected]>
@mkulke mkulke force-pushed the mkulke/add-az-tdx-vtpm-attester branch from b1c478b to 33f3d6b Compare December 27, 2023 08:39
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xynnn007 Xynnn007 merged commit 7185ae7 into confidential-containers:main Dec 30, 2023
17 checks passed
@mkulke mkulke deleted the mkulke/add-az-tdx-vtpm-attester branch December 30, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants