Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update occlum ci #592

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

Xynnn007
Copy link
Member

Now we are using a ACTIONS_RUNNER_HOOK_JOB_COMPLETED ability provided by github action. This allows us not to explicitly define a post-run script in yaml. The post actions are defined onside the runner itself.

See documents: https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/running-scripts-before-or-after-a-job#triggering-the-scripts

cc @mythi

Now we are using a ACTIONS_RUNNER_HOOK_JOB_COMPLETED ability provided by
github action. This allows us not to explicitly define a post-run script
in yaml. The post actions are defined onside the runner itself.

See documents: https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners/running-scripts-before-or-after-a-job#triggering-the-scripts

Signed-off-by: Xynnn007 <[email protected]>
@Xynnn007
Copy link
Member Author

btw @BbolroC this would be a choice for IBM SE runner. The concrete repo could be decided by $GITHUB_REPOSITORY env in the script.

@Xynnn007 Xynnn007 marked this pull request as ready for review June 20, 2024 09:58
@Xynnn007 Xynnn007 requested a review from sameo as a code owner June 20, 2024 09:58
@BbolroC
Copy link
Member

BbolroC commented Jun 20, 2024

btw @BbolroC this would be a choice for IBM SE runner. The concrete repo could be decided by $GITHUB_REPOSITORY env in the script.

True, I will spread out this info to the CI guys for kata/confidential containers to remove those unnecessary steps in the workflows. Thanks a lot!

Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xynnn007 thanks!

@Xynnn007
Copy link
Member Author

After merging this PR, I propose to cut a release of v0.9.0 guest-components and trustee. Any thoughts? @fitzthum @arronwy @mythi

@arronwy arronwy merged commit d7feaf8 into confidential-containers:main Jun 21, 2024
4 checks passed
@Xynnn007 Xynnn007 deleted the fix-occlum-ci branch June 21, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants