Fixes inspired by Clippy #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
rebase needed here |
We don't need this return. Thank you clippy. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
fitzthum
force-pushed
the
clippy-fixes-1
branch
from
33e3af0 to
c1ab353
Compare
Rebased. TDX change no longer needed. |
mythi
reviewed
Feb 11, 2025
It's hard to imagine having multiple implementations of Extractors (the thing that manages all the individual extractors). So let's simplify things by getting rid of the ExtractorsImpl trait. Also rewrite some of the comments and remove a newline that Clippy was complaining about. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
fitzthum
force-pushed
the
clippy-fixes-1
branch
from
c1ab353 to
7e6b2ef
Compare
Xynnn007
approved these changes
Feb 12, 2025
mythi
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went a little further on the middle one and removed the
ExtractorsImpltrait.