This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Show actor type #10
Merged
Show actor type #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashedone
reviewed
Oct 1, 2024
lib/chain.ts
Outdated
Comment on lines
2
to
10
| export function getAddressType(_address: string) { | ||
| if (Math.random() < 0.5) { | ||
| return "account"; | ||
| } | ||
|
|
||
| return Math.random() < 0.5 ? "contract" : "validator"; | ||
| } |
There was a problem hiding this comment.
Could we mock it in a different way? That would be consistent between renders. Even a file with the list of contract addresses and validator addresses to hardcode/configure those temporarily would be better for testing and presentation purposes.
There was a problem hiding this comment.
Good point, maybe checking if the address contains some characters? That way it'd work for any address instead of those on a list
There was a problem hiding this comment.
I was thinking this way too. Anything predictable would work, I think.
abefernan
force-pushed
the
better-react-mermaid
branch
from
d7be3ce to
63e62d3
Compare
abefernan
force-pushed
the
show-actor-type
branch
from
7df2983 to
797d173
Compare
abefernan
force-pushed
the
better-react-mermaid
branch
from
63e62d3 to
0fa660c
Compare
abefernan
force-pushed
the
show-actor-type
branch
from
797d173 to
357a589
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2.
Adds a mock function that randomly tells you if an address is an account, a contract, or a validator. The diagram renders differently depending on that type of address.
An account sends to a contract:
A validator sends to an account:
